-
Notifications
You must be signed in to change notification settings - Fork 50
UID2-5741 Add notes about --kubernetes-version #902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -277,6 +277,9 @@ az aks create \ | |||
--nodepool-name oprnodepool \ | |||
--os-sku Ubuntu | |||
``` | |||
:::note | |||
Make sure to use the latest supported `--kubernetes-version`, otherwise Long Term Support(LTS) is required to be enabled (See https://learn.microsoft.com/en-us/azure/aks/long-term-support). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"make sure to" is not grammatical. You could say be sure to... or make sure that you... (plus formatting for URL).
Suggest:
Be sure to use the latest supported Kubernetes version, using the --kubernetes-version
flag. If you use an earlier version, you must enable Long Term Support (LTS). For details, see Long-term support for Azure Kubernetes Service (AKS) versions.
@@ -277,6 +277,9 @@ az aks create \ | |||
--nodepool-name oprnodepool \ | |||
--os-sku Ubuntu | |||
``` | |||
:::note | |||
Be sure to use the latest supported Kubernetes version, using the `--kubernetes-version` flag. If you use an earlier version, you must enable Long Term Support (LTS). For details, see [Long-term support for Azure Kubernetes Service (AKS) versions](https://learn.microsoft.com/en-us/azure/aks/long-term-support). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small things: 1) long-term, hyphenated, 2) for external links we generally say "in the..." to indicate that it's an external link. Suggest:
Be sure to use the latest supported Kubernetes version, using the --kubernetes-version
flag. If you use an earlier version, you must enable Long-Term Support (LTS). For details, see Long-term support for Azure Kubernetes Service (AKS) versions in the Microsoft documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! One edit marked otherwise good to go.
Note: I was going to suggest we could make these changes in the Japanese file as well, but there's a mix of code changes and copy changes so I agree with your choice to leave those for the translator :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thx!
No description provided.