Skip to content

UID2-5741 Add notes about --kubernetes-version #902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 15, 2025

Conversation

cYKatherine
Copy link
Contributor

No description provided.

@cYKatherine cYKatherine self-assigned this Jul 1, 2025
@@ -277,6 +277,9 @@ az aks create \
--nodepool-name oprnodepool \
--os-sku Ubuntu
```
:::note
Make sure to use the latest supported `--kubernetes-version`, otherwise Long Term Support(LTS) is required to be enabled (See https://learn.microsoft.com/en-us/azure/aks/long-term-support).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"make sure to" is not grammatical. You could say be sure to... or make sure that you... (plus formatting for URL).

Suggest:

Be sure to use the latest supported Kubernetes version, using the --kubernetes-version flag. If you use an earlier version, you must enable Long Term Support (LTS). For details, see Long-term support for Azure Kubernetes Service (AKS) versions.

@cYKatherine cYKatherine changed the title UID2-4751 Add notes about --kubernetes-version UID2-5741 Add notes about --kubernetes-version Jul 15, 2025
@@ -277,6 +277,9 @@ az aks create \
--nodepool-name oprnodepool \
--os-sku Ubuntu
```
:::note
Be sure to use the latest supported Kubernetes version, using the `--kubernetes-version` flag. If you use an earlier version, you must enable Long Term Support (LTS). For details, see [Long-term support for Azure Kubernetes Service (AKS) versions](https://learn.microsoft.com/en-us/azure/aks/long-term-support).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small things: 1) long-term, hyphenated, 2) for external links we generally say "in the..." to indicate that it's an external link. Suggest:

Be sure to use the latest supported Kubernetes version, using the --kubernetes-version flag. If you use an earlier version, you must enable Long-Term Support (LTS). For details, see Long-term support for Azure Kubernetes Service (AKS) versions in the Microsoft documentation.

Copy link
Collaborator

@genwhittTTD genwhittTTD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One edit marked otherwise good to go.
Note: I was going to suggest we could make these changes in the Japanese file as well, but there's a mix of code changes and copy changes so I agree with your choice to leave those for the translator :-)

@genwhittTTD genwhittTTD self-requested a review July 15, 2025 23:10
Copy link
Collaborator

@genwhittTTD genwhittTTD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thx!

@cYKatherine cYKatherine merged commit 5b07ed7 into main Jul 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants